Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial Bicep sample #333

Merged
merged 6 commits into from
Aug 10, 2021
Merged

add initial Bicep sample #333

merged 6 commits into from
Aug 10, 2021

Conversation

glennmusa
Copy link
Contributor

Add an initial sample of MLZ in Bicep to the long-lived /bicep branch for co-development

@glennmusa glennmusa changed the title add initial MLZ sample in Bicep add initial Bicep sample Aug 6, 2021
Copy link
Contributor

@Breanna-Stryker Breanna-Stryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it all obviously. This is just an initial, we might want to have a conversation about adding some comments throughout. I don't know if they are helpful or not ultimately to end users; but I also don't want to be the person to say 'It's self documenting.'

@glennmusa
Copy link
Contributor Author

glennmusa commented Aug 10, 2021

I love it all obviously. This is just an initial, we might want to have a conversation about adding some comments throughout. I don't know if they are helpful or not ultimately to end users; but I also don't want to be the person to say 'It's self documenting.'

Agreed. We should make more judicious use of the @description('This field is X') decorator too.

@glennmusa glennmusa merged commit 1afa277 into bicep Aug 10, 2021
@glennmusa glennmusa deleted the glennmusa/initialBicep branch August 10, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants