Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally deploy built-in Policy Initiatives for NIST 800-53, CMMC Level 3, or DOD IL5 #397

Merged
merged 20 commits into from
Sep 9, 2021

Conversation

shawngib
Copy link
Member

@shawngib shawngib commented Sep 7, 2021

Description

Add parameter based deployment for Policy initiative deployment of NIST/CMMC/IL5 as needed.

Issue reference

The issue this PR will close: #387

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa changed the title Sg bicep policy #387 optionally deploy built-in Policy Initiatives for NIST 800-53, CMMC Level 3, or DOD IL5 Sep 7, 2021
Copy link
Member Author

@shawngib shawngib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to revert back. The original was correct when testing it works as expected with original not with new line.
Original:

var modifiedAssignment = (environment().name =~ 'AzureCloud' && builtInAssignment =~ 'IL5' ? 'NIST' : builtInAssignment)

Example command: az deployment group create --resource-group mlz-rnvmkhkcgceda-operations --name sg-mlztest1 --template-file ./src/bicep/modules/policyAssignment.bicep --parameters builtInAssignment=CMMC logAnalyticsWorkspaceName=mlz-rnvmkhkcgceda-laws
@glennmusa
Copy link
Contributor

glennmusa commented Sep 8, 2021

Need to revert back. The original was correct when testing it works as expected with original not with new line.
Original:

var modifiedAssignment = (environment().name =~ 'AzureCloud' && builtInAssignment =~ 'IL5' ? 'NIST' : builtInAssignment)

Huh, my mistake. Looks like I need to read up on inline function evaluation in Bicep! My assumption was (environment().name =~ 'AzureCloud' && builtInAssignment =~ 'IL5') ? 'NIST' : builtInAssignment

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes for references and naming, everything worked great and deployed with NIST, IL5, and CMMC in AzureUsGovernment and AzureCloud

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @shawngib 🎉

@glennmusa glennmusa merged commit 04f8771 into Azure:bicep Sep 9, 2021
Breanna-Stryker added a commit that referenced this pull request Sep 17, 2021
* prefer local backends for terraform

* add a Bicep Azure Sentinel module (#385)

* Remove Client/Client Secret/Tenant Vars from Terraform Templates

Co-authored-by: Bree Stryker <[email protected]>

* add workflows to lint and build .bicep modules (#400)

* disable verbose lint output (#402)

* optionally deploy built-in Policy Initiatives for NIST 800-53, CMMC Level 3, or DOD IL5 (#397)

* log activities from subscriptions used in a deployment into the Operations log analytics workspace (#412)

* optionally deploy Azure Bastion Host from the base deployment (#406)

Co-authored-by: Vidya Bala <[email protected]>
Co-authored-by: Bree Stryker <[email protected]>
Co-authored-by: Glenn Musa <[email protected]>
Co-authored-by: Shawn Gibbs <[email protected]>
@glennmusa glennmusa mentioned this pull request Oct 14, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants