Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings for unnecessary Bicep dependsOn statements #596

Merged
merged 1 commit into from
Jan 3, 2022
+0 −15
Merged

Fix warnings for unnecessary Bicep dependsOn statements #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixed warnings for unnecessary dependsOn
@brooke-hamilton
brooke-hamilton committed Dec 31, 2021
commit 3bd75bd460c5debc2008a0ce4a411b12a0167545
6 changes: 0 additions & 6 deletions src/bicep/modules/linuxVirtualMachine.bicep
View file
Original file line number Diff line number Diff line change
@@ -86,7 +86,6 @@ resource networkWatcher 'Microsoft.Compute/virtualMachines/extensions@2020-06-01
typeHandlerVersion: '1.4'
}
dependsOn: [
virtualMachine
policyExtension
]
}
@@ -102,9 +101,6 @@ resource policyExtension 'Microsoft.Compute/virtualMachines/extensions@2020-12-0
autoUpgradeMinorVersion: true
enableAutomaticUpgrade: true
}
dependsOn: [
virtualMachine
]
}

resource omsExtension 'Microsoft.Compute/virtualMachines/extensions@2020-06-01' = {
@@ -123,7 +119,6 @@ resource omsExtension 'Microsoft.Compute/virtualMachines/extensions@2020-06-01'
}
}
dependsOn: [
virtualMachine
networkWatcher
]
}
@@ -138,7 +133,6 @@ resource dependencyAgent 'Microsoft.Compute/virtualMachines/extensions@2020-06-0
autoUpgradeMinorVersion: true
}
dependsOn: [
virtualMachine
omsExtension
]
}
9 changes: 0 additions & 9 deletions src/bicep/modules/windowsVirtualMachine.bicep
View file
Original file line number Diff line number Diff line change
@@ -68,9 +68,6 @@ resource dependencyAgent 'Microsoft.Compute/virtualMachines/extensions@2021-04-0
typeHandlerVersion: '9.5'
autoUpgradeMinorVersion: true
}
dependsOn: [
windowsVirtualMachine
]
}

resource policyExtension 'Microsoft.Compute/virtualMachines/extensions@2021-04-01' = {
@@ -100,9 +97,6 @@ resource mmaExtension 'Microsoft.Compute/virtualMachines/extensions@2021-04-01'
workspaceKey: listKeys(logAnalyticsWorkspaceId , '2015-11-01-preview').primarySharedKey
}
}
dependsOn: [
windowsVirtualMachine
]
}

resource networkWatcher 'Microsoft.Compute/virtualMachines/extensions@2020-06-01' = {
@@ -113,7 +107,4 @@ resource networkWatcher 'Microsoft.Compute/virtualMachines/extensions@2020-06-01
type: 'NetworkWatcherAgentWindows'
typeHandlerVersion: '1.4'
}
dependsOn: [
windowsVirtualMachine
]
}