Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added webclient and updates #910

Merged

Conversation

shawntmeyer
Copy link
Contributor

Description

Changed custom software download to webclient download to improve performance and prevent timeouts. Found that anything over 10GB downloads with Invoke-WebRequest timed out with the runCommand timeout of 90 minutes. Same download took less than 10 mins with webclient.

Added Microsoft Updates capability to image build allowing Microsoft Update, Windows Update, and WSUS options.

When building my branch, bicep immediately reported issues with the Tier3 deployment which I did not modify. Please investigate!

Issue reference

The issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • [] Manual tests have passed
  • Relevant issues are linked to this PR

@shawntmeyer shawntmeyer requested a review from a team as a code owner February 24, 2024 23:31
@jamasten jamasten linked an issue Feb 26, 2024 that may be closed by this pull request
@jamasten jamasten changed the base branch from main to shawntmeyer-imaging-updates February 26, 2024 12:07
Copy link
Contributor

@jamasten jamasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging into a feature branch for testing and fixes, if needed.

@jamasten jamasten merged commit bcb9c8b into Azure:shawntmeyer-imaging-updates Feb 26, 2024
3 checks passed
jamasten pushed a commit that referenced this pull request Mar 1, 2024
jamasten added a commit that referenced this pull request Mar 11, 2024
* added webclient and updates (#910)

Co-authored-by: Shawn Meyer <[email protected]>

* added webclient and updates (#910)

Co-authored-by: Shawn Meyer <[email protected]>

* Fixed network address prefixes

* Moved file

* Moved file

* Moved file

* Moved & renamed files

* Moved & renamed files

* Updated to support all networks

* Moved files

* Added new resources

* Moved file, Updated param

* Moved files

* Moved file

* Created central naming convention file

* Merged monitoring resources into a parent deployment

* Created file to generate names based on networks

* Updated locations & module location

* Refactoring

* Unified UI

* Renamed file

* Refactored module

* Renamed the file

* Renamed the file, added condition, fixed name

* Added property to hub for logging condition

* Renamed the module

* Refactored diags & policy

* Renamed file, added scope

* Fixed symbolic name, module file, & params

* Refactored DfC

* Removed default values & passed parent value in

* Compiled bicep changes

* Fixed name for PLS

* Fixed params for virtual network links

* Fixed storage IDs for output

* Fixed deployment name

* Fixed diagnostics deployment name & looping

* Updated param name

* Added files

* Added param descriptions & necessary deployments

* Updated param name

* Updated param properties

* Added output for subnet resource ID

* Organized params

* Organized params

* Added required params for tier 3

* Organized params

* Added param for network watcher

* Added outputs

* Added & updated resource names

* Fixed params & vars, Added outputs for values

* Compiled bicep changes

* Added names for resources

* Fixed PIP diag deployment name

* Fixed param name

* Fixed param name

* Fixed param name

* Fixed param name

* Added abbreviation for compute gallery

* Compiled bicep changes

* Updated build scope

* Added default value for param

* Reduced name lengths for VMs

* Added output for disk encryption set

* Updated disk encryption set resource ID value

* Compiled bicep changes

* Added inputs for new params, Removed missing params

* Removed unnecessary NSG rules on spokes

* Added param for network watcher

* Fixed sub ID reference

* Added default name for action group

* Fixed name in logic for tier3

* Fixed default value for update service

* Fixed dependency for RG

* Removed unnecessary params

* Compiled tier3 changes

* Removed action group name

* Changed step name, Fixed conditions

* Removed input for private DNS zones

* Organized steps & sections

* Added API enhancement for firewall input

* Added defender condition

* Fixed syntax on output param

* Fixed resource IDs for pvt dns zones

* Fixed name for mgmt vm

* Fixed image build vm name

* Added RG dependency for Azure policy

* Updated law drop down to default to ops law

* Made deployment names unique for restarts

* Fixed resource id

* Fixed compute gallery name

* GitHub Action: Build Bicep to JSON

---------

Co-authored-by: Shawn Meyer <[email protected]>
Co-authored-by: Shawn Meyer <[email protected]>
Co-authored-by: github-actions <[email protected]>
jwaltireland pushed a commit to ARPA-H/AzureMissionLZ that referenced this pull request Nov 14, 2024
* added webclient and updates (Azure#910)

Co-authored-by: Shawn Meyer <[email protected]>

* added webclient and updates (Azure#910)

Co-authored-by: Shawn Meyer <[email protected]>

* Fixed network address prefixes

* Moved file

* Moved file

* Moved file

* Moved & renamed files

* Moved & renamed files

* Updated to support all networks

* Moved files

* Added new resources

* Moved file, Updated param

* Moved files

* Moved file

* Created central naming convention file

* Merged monitoring resources into a parent deployment

* Created file to generate names based on networks

* Updated locations & module location

* Refactoring

* Unified UI

* Renamed file

* Refactored module

* Renamed the file

* Renamed the file, added condition, fixed name

* Added property to hub for logging condition

* Renamed the module

* Refactored diags & policy

* Renamed file, added scope

* Fixed symbolic name, module file, & params

* Refactored DfC

* Removed default values & passed parent value in

* Compiled bicep changes

* Fixed name for PLS

* Fixed params for virtual network links

* Fixed storage IDs for output

* Fixed deployment name

* Fixed diagnostics deployment name & looping

* Updated param name

* Added files

* Added param descriptions & necessary deployments

* Updated param name

* Updated param properties

* Added output for subnet resource ID

* Organized params

* Organized params

* Added required params for tier 3

* Organized params

* Added param for network watcher

* Added outputs

* Added & updated resource names

* Fixed params & vars, Added outputs for values

* Compiled bicep changes

* Added names for resources

* Fixed PIP diag deployment name

* Fixed param name

* Fixed param name

* Fixed param name

* Fixed param name

* Added abbreviation for compute gallery

* Compiled bicep changes

* Updated build scope

* Added default value for param

* Reduced name lengths for VMs

* Added output for disk encryption set

* Updated disk encryption set resource ID value

* Compiled bicep changes

* Added inputs for new params, Removed missing params

* Removed unnecessary NSG rules on spokes

* Added param for network watcher

* Fixed sub ID reference

* Added default name for action group

* Fixed name in logic for tier3

* Fixed default value for update service

* Fixed dependency for RG

* Removed unnecessary params

* Compiled tier3 changes

* Removed action group name

* Changed step name, Fixed conditions

* Removed input for private DNS zones

* Organized steps & sections

* Added API enhancement for firewall input

* Added defender condition

* Fixed syntax on output param

* Fixed resource IDs for pvt dns zones

* Fixed name for mgmt vm

* Fixed image build vm name

* Added RG dependency for Azure policy

* Updated law drop down to default to ops law

* Made deployment names unique for restarts

* Fixed resource id

* Fixed compute gallery name

* GitHub Action: Build Bicep to JSON

---------

Co-authored-by: Shawn Meyer <[email protected]>
Co-authored-by: Shawn Meyer <[email protected]>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imaging: Add operating system updates
2 participants