-
Notifications
You must be signed in to change notification settings - Fork 168
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #155 from gapag/master
Add ANTLR4 Java backend
- Loading branch information
Showing
20 changed files
with
1,298 additions
and
291 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
ecf4fed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using the Java backend I now get this error:
The file is apparently called
CPP/_cup.cup
. Seems like this regression was introduced with this commit?ecf4fed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read only now your comment, just because I was looking at this merge (I got no notification). I will try to fix this.
Is it possible to add your test case to the test suite?
ecf4fed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this happens with any grammar when using the Java backend.
Maybe the automatic tests don't test the Java backend at all?
ecf4fed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gdetrez The automatic tests should, as I read from their logs.
I cloned anew the repository on a computer that had never known BNFC in any sense; and I had no problem running the Java backend with JFlex/JLex and CUP.
After compiling with
make build
I ran, separately,and running
make
in each case shows that CUP got its input and processed it properly.Could you send some more information, e.g. the command line you are using, input files, files generated etc etc
ecf4fed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automated test do check the java backend (and pass) and I can't reproduce this either.
@johnjcamilleri did you try re-generating the makefile (bnfc option
-m
)?ecf4fed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I wasn't re-generating the Makefile with
-m
. But am I right that the naming of the cup file has changed recently? I came across this when trying to compile other people's code (student solutions) using their makefiles.ecf4fed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are. I did change it and I have no documented reason for that (might have been a typo).
If needed we can revert to the old naming convention, just by modifying the
cupmakedetail
function inJava.hs
.