-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a method for specifying binary data in STRING and BLOCK default values #261
Comments
@ryanatball @jasonatball Can I get a vote from you guys? I've been digging into this, and I think there are essentially 3 ways it could be implemented:
Do you guys have a preference? Or do you see another way I'm missing? |
The only items with default values are parameters. If a parameter is a BLOCK and the default is "0xABCD" then we translate that into binary. I think that makes the most sense to people. If the parameter is a STRING and the default is "0xABCD" we leave it as a string. Strings and strings and blocks are binary. So I vote 2 but only support BLOCK. |
There are cases with STRING where you still need to be able specify hex. (CR/NL/TAB) for example. Using, 0x as a detection prefix is fine. It would be nice if the string was quoted "0x00", that it would not convert to binary, but unquoted 0x00 would. Ryan |
…eated as binary, quotes strings that start with 0x are preserved. Also do some refactoring to remove one of two similar functions that were converting packet information into a command string.
re #261 Add mechanism to define a binary string for STRING/BLOCK defa…
Closed with f06acc8 |
Merge in COSMOSEE/base from imageviewer-doc to master * commit '584c3757e4ac82a61fd1e1e2ffb277584ebbcdc5': Document ImageviewerWidget Fix ImageViewer bug when packetItems is null
No description provided.
The text was updated successfully, but these errors were encountered: