Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonDRb retry if first attempt hits a closed socket #94

Closed
ghost opened this issue Mar 20, 2015 · 0 comments
Closed

JsonDRb retry if first attempt hits a closed socket #94

ghost opened this issue Mar 20, 2015 · 0 comments
Labels
bug
Milestone
v3.3.3

Comments

@ghost
Copy link

ghost commented Mar 20, 2015

JsonDRb needs to retry once if sending the Json request discovers a broken socket. This allows the Command and Telemetry Server to be restarted without causing unexpected errors in ScriptRunner for example. To recreate:

  1. Start CmdTlmServer
  2. Start ScriptRunner
  3. Send a command from ScriptRunner
  4. Close CmdTlmServer
  5. Start CmdTlmServer
  6. Try to send a command from ScriptRunner
@ghost ghost added the bug label Mar 20, 2015
ghost pushed a commit that referenced this issue Mar 20, 2015
@ryanmelt
#94. Also close client sockets when shutting down JsonDRb service
33485eb
ghost pushed a commit that referenced this issue Mar 20, 2015
@ryanmelt
#94 Properly clean up client threads on JsonDRb shutdown
adabaad
jmthomas added a commit that referenced this issue Mar 23, 2015
@jmthomas
Refactor method_missing #94
983d959
ghost pushed a commit that referenced this issue Mar 23, 2015
@ryanmelt
#94 Move setting socket to nil and add debugging for Travis
ddcddc6
ghost pushed a commit that referenced this issue Mar 23, 2015
@ryanmelt
#94. Disconnect if no response data
e3a9c9b
ghost pushed a commit that referenced this issue Mar 23, 2015
@ryanmelt
#94 Dont loop forever retrying
abe95ec
ghost pushed a commit that referenced this issue Mar 23, 2015
@ryanmelt
#94 Remove debugging code
9f24eb6
@ghost ghost closed this as completed in 13072bf Mar 23, 2015
@ghost ghost added this to the v3.3.2 milestone Mar 23, 2015
ghost pushed a commit that referenced this issue May 19, 2021
Pull request #94: Test on linux and update cacert url
a64136a 
Merge in COSMOSEE/base from linux-patch-cert-url-update to master

* commit '541428a15ac6b6acc71fede189c074514062ef14':
  Test on linux and update cacert url
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v3.3.3
Development

No branches or pull requests
0 participants