closes #125 Fix COSMOS issues for qtbindings 4.8.6.2 #128
Conversation
| result = nil | ||
| Qt.execute_in_main_thread(true, 0.05) do | ||
| window = nil | ||
| window = get_cmd_tlm_gui_window() if get_cmd_tlm_gui_window() | ||
| msg = Qt::MessageBox.new(window) | ||
| msg.setIcon(icon) | ||
| msg.setIcon(Qt::MessageBox::Warning) |
There was a problem hiding this comment.
Was this actually an issue or just an enhancement?
There was a problem hiding this comment.
Accessing the Qt Constant outside of GUI context was invoking method missing and potentially a problem (It raised my new exception).
|
Looks good. Surprised we never had an issue with the TlmGrapher fix. We definitely call that code in our tests. |
|
So 4.8.6.2 has my method caching in it too? |
|
Yes. 4.8.6.2 has the method caching and the checks for making sure we're in the main thread. I bumped the gemspec to require at least 4.8.6.2 from now on. The improvements justify the requirement. Expect to get some problem reports from people installing older COSMOS with the current qtbindings and then having programs crash because they are now detecting the improper GUI context outside the main thread. Just need to tell them they have to either downgrade qtbindings to 4.8.6.1 (which sucks because your performance improvements are a big deal), or upgrade COSMOS. |
1 similar comment
closes #125 Fix COSMOS issues for qtbindings 4.8.6.2
ghost
merged commit 
Merge in COSMOSEE/base from fix-scriptrunner-tests to master * commit '34116621ea9683ecfdbf54c0f7add8caba48a7c3': fix scriptrunner tests add headers arg to api functions
@jmthomas Please review