Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clear_all which can also take a target name #433 #447

Merged
2 commits merged into from
May 10, 2017
Merged

Add clear_all which can also take a target name #433 #447

2 commits merged into from
May 10, 2017

Conversation

ghost
Copy link

@ghost ghost commented May 10, 2017

No description provided.

@ghost ghost self-requested a review May 10, 2017 16:27
@coveralls
Copy link

coveralls commented May 10, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 85.709% when pulling b7c2533 on tlm_viewer_clear_all into ba2e8c2 on master.

@coveralls
Copy link

coveralls commented May 10, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 85.752% when pulling b7c2533 on tlm_viewer_clear_all into ba2e8c2 on master.

ghost
ghost suggested changes May 10, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix specs and update cosmosrb.com with version 3.9.2 noted. Probably need to default target_name to nil internally for clear all as well.

lib/cosmos/tools/tlm_viewer/tlm_viewer.rb Outdated

# Close all screens
def clear_all(target_name)
if target_name.empty?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why empty instead of nil?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 85.726% when pulling c7c4b9a on tlm_viewer_clear_all into ba2e8c2 on master.

@coveralls
Copy link

coveralls commented May 10, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 85.769% when pulling c7c4b9a on tlm_viewer_clear_all into ba2e8c2 on master.

@ghost ghost merged commit 4633e63 into master May 10, 2017
@ghost ghost deleted the tlm_viewer_clear_all branch May 10, 2017 18:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coveralls @jmthomas