Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #49 Make About Dialog Scroll #53

Merged
2 commits merged into from
Feb 10, 2015
Merged

closes #49 Make About Dialog Scroll #53

2 commits merged into from
Feb 10, 2015

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2015

@jmthomas Please Review

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.01% when pulling 5a06bb0 on make-about-dialog-scroll into da85b8e on master.

@jmthomas
Copy link
Contributor

👍 Works well. Only comment would be to put the OK button on the bottom of the window so you don't have to scroll down to see it. Might be confusing to some users. I'd also put the x, y, width, height down there so it's easier to get to without scrolling.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.0% when pulling f1c4bc2 on make-about-dialog-scroll into da85b8e on master.

ghost pushed a commit that referenced this pull request Feb 10, 2015
@ghost ghost merged commit 651f514 into master Feb 10, 2015
@ghost ghost deleted the make-about-dialog-scroll branch February 10, 2015 21:12
ghost pushed a commit that referenced this pull request Apr 5, 2021
Merge in COSMOSEE/base from singlespa-final to master

* commit '25ce1baec6ee59b891b934d8a8bf7dcc3a5e02da':
  merge icon changes.  Recreate RuxIcon.  Still needs a little love
  fix bugs
  fix vscode
  fix merge errors with TlmViewer
  Working single-spa
  cmd_tlm_api\app\controllers\tools_controller.rb
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants