Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re #82 Improve COSMOS startup speed #83

Merged
1 commit merged into from
Mar 13, 2015
Merged

re #82 Improve COSMOS startup speed #83

1 commit merged into from
Mar 13, 2015

Conversation

ghost
Copy link

@ghost ghost commented Mar 13, 2015

@jmthomas Please Review.

Unmarshalled startup speed on my current program went from 164 seconds down to 10 seconds.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 91.29% when pulling 348ce70 on improve-startup-speed into fc3772d on master.

@jmthomas
Copy link
Contributor

Wow, that's a huge improvement. TlmViewer has a huge startup speed too. Was this just removing the iteration through all the items each time? Approved!

@ghost
Copy link
Author

ghost commented Mar 13, 2015

There were two main pain points. One was building the limits item cache. The other was sleeping waiting for the GUI to update the progress bar. I fixed both issues.

ghost pushed a commit that referenced this pull request Mar 13, 2015
@ghost ghost merged commit 8403d38 into master Mar 13, 2015
@ghost ghost deleted the improve-startup-speed branch March 13, 2015 18:48
@ghost ghost mentioned this pull request Mar 13, 2015
ghost pushed a commit that referenced this pull request Apr 12, 2021
Merge in COSMOSEE/base from targets_modified_folder to master

* commit '3a7e3d5f86ab184a32768720379313357d52e7ac':
  switch to targets_modified
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants