Run Black code formatter #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was a useful test. I will handle it in the Clean Outdate Code PR because we should remove pep8 at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies Black since it's an improvement on pep8, which required manual enforcement of style guides. The only configurable element in Black is line length. The default is 88 characters which actually seems pretty reasonable, so I maintained the default. Otherwise, I think we should use Black as intended to enforce whatever rules they use to standardize our code. I will make sure the instructions on how to install and run Black end up in our repo docs (it's very simple).
Black doesn't apply line length limitations to code comments and has said that they won't: psf/black#1713, so unfortunately this needs to be done manually. Black also doesn't support Python 2 code, so did not run on some files. None of these were model scripts though and should all be getting cleaned out of the repo.