starting proportional elcm fixes #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we sometimes overfill buildings in the current code; working to fix
problem here was that groupby_random_choice doesn't support choosing from a group that doesn't exist. in the proportional model we sometimes ask to increase retail or gov/edu in a city / zone_id which does not have the correct building types this also requires changes in orca that are still being litigated
these changes will have to be reversed when my PR on orca gets merged: UDST/orca#20
|
These are fixes which put jobs from the proportional jobs model into the right building types. This can overfill those buildings, so more work will have to be done, probably to increase prices so that more development occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we sometimes overfill buildings in the current code; working to fix