Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various docs fixes #18

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Various docs fixes #18

merged 4 commits into from
Dec 23, 2024

Conversation

oblm
Copy link
Collaborator

@oblm oblm commented Nov 24, 2024

This PR collects various docs fixes that I'm drive by implementing as I read the docs for the first time. @JoelOtter I will let you know when this is ready for review.

Update: This PR is now ready for review. It includes all fixes necessary to make this setup flow function correctly on macOS. These are:

  • Correct the path to test_app
  • Correct the ./growl-cmd assets to take into account the fact that assets is two directories back, not one.
  • Add make as a dependency.
  • Link to the homebrews for make and cmake to help users find dependencies and push them towards using the homebrew workflow that we use.

I will land a second PR at some point that adds Windows steps and distinguished between Windows and macOS/Linux steps

@oblm oblm requested a review from JoelOtter December 23, 2024 16:14
@JoelOtter JoelOtter merged commit b2f4b3e into main Dec 23, 2024
7 checks passed
@JoelOtter JoelOtter deleted the docs/various-fixes branch December 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants