You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
With an EditContext model containing one or more sub-objects, eg a Customer which has an Address, the FieldIdentifier.Model for the changed field will be different to the root object when Address properties have changed. For example, if Address.FirstLine changes, FieldIdentifier.Model will be of type Address, so a registered IValidator<Address> validator will be used to validate at the field-level instead of IValidator<Customer> like at the model-level.
This means an exception is thrown when blurring out of Address fields if an IValidator<Customer> is provided to <FluentValidationValidator> via the Validator property.
If a Validator is not provided, and one is instead retrieved from DI / assembly scan, then any rules affecting the Address that are defined on the IValidator<Customer> validator will not be executed, leading to inconsistent behaviour between model-level and field-level validation.
Also, when validating at the field-level, any configuration provided to the mounted <FluentValidationValidator> component (eg RuleSets) is ignored. The RuleSet will be used for whole-model validation, but ignored for field-level validation, as the configuration is not passed to the validator. At the field-level, rules are executed purely based on the property name, ignoring other configuration.
The same model-level validation rules apply to field-level validation, but scoped to the changed property.
If options are passed to <FluentValidationValidator>, that configuration is used to validate both the whole model and individual fields
If a Validator is provided to <FluentValidationValidator>, it is possible to validate sub object fields without an exception being thrown
If a Validator is not provided, the type of EditContext.Model is used to locate a validator instead of FieldIdentifier.Model, so that rules defined on the root-level validator are ran.
In the demo app, I've put together a proposal for how it could behave - pages suffixed with "Fixed" use a modified version of Blazored.FluentValidation with the changes in #205
Screenshots
N/A
Hosting Model (is this issue happening with a certain hosting model?):
N/A
The text was updated successfully, but these errors were encountered:
Describe the bug
With an EditContext model containing one or more sub-objects, eg a
Customer
which has anAddress
, theFieldIdentifier.Model
for the changed field will be different to the root object whenAddress
properties have changed. For example, ifAddress.FirstLine
changes,FieldIdentifier.Model
will be of typeAddress
, so a registeredIValidator<Address>
validator will be used to validate at the field-level instead ofIValidator<Customer>
like at the model-level.This means an exception is thrown when blurring out of Address fields if an
IValidator<Customer>
is provided to<FluentValidationValidator>
via theValidator
property.If a Validator is not provided, and one is instead retrieved from DI / assembly scan, then any rules affecting the
Address
that are defined on theIValidator<Customer>
validator will not be executed, leading to inconsistent behaviour between model-level and field-level validation.Also, when validating at the field-level, any configuration provided to the mounted
<FluentValidationValidator>
component (eg RuleSets) is ignored. The RuleSet will be used for whole-model validation, but ignored for field-level validation, as the configuration is not passed to the validator. At the field-level, rules are executed purely based on the property name, ignoring other configuration.To Reproduce
I've put together a small Blazor Server app to demonstrate the issues: https://github.com/matthetherington/BlazoredFluentValidationIssueDemo
Expected behavior
<FluentValidationValidator>
, that configuration is used to validate both the whole model and individual fields<FluentValidationValidator>
, it is possible to validate sub object fields without an exception being thrownEditContext.Model
is used to locate a validator instead ofFieldIdentifier.Model
, so that rules defined on the root-level validator are ran.In the demo app, I've put together a proposal for how it could behave - pages suffixed with "Fixed" use a modified version of Blazored.FluentValidation with the changes in #205
Screenshots
N/A
Hosting Model (is this issue happening with a certain hosting model?):
N/A
The text was updated successfully, but these errors were encountered: