Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in update_chunk #407

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Fix bug in update_chunk #407

merged 1 commit into from
Jun 28, 2022

Conversation

martaiborra
Copy link
Collaborator

@martaiborra martaiborra commented Jun 28, 2022

If a special chunk is added to a schunk, the chunk file is not created leaving its index for another non special value chunk. But when updating it by a non special value chunk, a new index must be found in order to not overwrite an existing chunk.

Copy link
Member

@FrancescAlted FrancescAlted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the test modification is checking the buggy case. Other than that, LGTM.

@martaiborra martaiborra merged commit d4bf086 into main Jun 28, 2022
@martaiborra martaiborra deleted the update_bug branch June 28, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants