Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

use set to check if feature names match #169

Merged
merged 1 commit into from
Apr 30, 2020
Merged

use set to check if feature names match #169

merged 1 commit into from
Apr 30, 2020

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Apr 30, 2020

The CPP features and Python features are just appended to each other in the function below.

feature_names += pyfeatures.all_pyfeatures

Their order is not guaranteed to be the same.
This is one of the reasons why PR #165 is failing.

This PR simply puts them into sets and checks if the sets are equal.

@wvangeit wvangeit merged commit c2111a8 into BlueBrain:master Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants