Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

interpolate current if present #318

Merged

Conversation

AurelienJaquier
Copy link
Collaborator

also in tests:
-use ms for time fro current datafile
-remove test_current (not useful since current is interpolated now)
-actually check efel output in test_interpolate_current

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b2ee3df) 53.45% compared to head (e7565d8) 53.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   53.45%   53.44%   -0.01%     
==========================================
  Files          30       30              
  Lines        8390     8397       +7     
  Branches     3671     3677       +6     
==========================================
+ Hits         4485     4488       +3     
  Misses       1263     1263              
- Partials     2642     2646       +4     
Files Coverage Δ
tests/test_pyfeatures.py 100.00% <100.00%> (ø)
efel/cppcore/LibV1.cpp 36.93% <33.33%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thanks!

@AurelienJaquier AurelienJaquier merged commit 1a24079 into BlueBrain:master Sep 28, 2023
@AurelienJaquier AurelienJaquier deleted the interpolate-current branch September 28, 2023 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants