This repository was archived by the owner on Feb 26, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
replace C++ exit(1) statements with exception handling #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 57.04% 57.05%
=======================================
Files 29 30 +1
Lines 7825 7847 +22
Branches 3264 3273 +9
=======================================
+ Hits 4464 4477 +13
- Misses 846 850 +4
- Partials 2515 2520 +5
☔ View full report in Codecov by Sentry. |
ilkilic
reviewed
Oct 20, 2023
ilkilic
reviewed
Oct 20, 2023
This reverts commit 954613a.
ilkilic
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
exit(1)
is called within a C++ library that's being used by Python (e.g., through a Python API), it will terminate the entire process.This PR replaces the
exit(1)
statements with exception handling. It further translates C++ exceptions to Python's built-in exceptions to enable graceful failures.Given the frequent use of exit calls throughout eFEL – appearing in over 15 distinct locations, notably within the frequently used LinearInterpolation function – this update is expected to prevent approximately 95% of potential future crashes.
Related to #321 .