Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Add Py312 wheel building + testing #345

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Add Py312 wheel building + testing #345

merged 5 commits into from
Jan 8, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Jan 5, 2024

Pull Request Template

Description

Adds CPython3.12 wheel built deployment and testing.
Update actions/setup-python from v2 to v4.

Checklist:

  • Unit tests are added to cover the changes.
  • The changes are mentioned in the documentation.
  • CHANGELOG.md is updated (skip if the change is not important for the changelog).

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8185fd8) 56.47% compared to head (0833b8d) 56.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   56.47%   56.49%   +0.01%     
==========================================
  Files          30       30              
  Lines        7727     7727              
  Branches     3274     3274              
==========================================
+ Hits         4364     4365       +1     
  Misses        843      843              
+ Partials     2520     2519       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just curious, why did you have to add setuptools to tox coverage?

@anilbey
Copy link
Contributor Author

anilbey commented Jan 8, 2024

Just curious, why did you have to add setuptools to tox coverage?

In Python3.12 setuptools is no longer installed by default for the environments created with venv.

https://docs.python.org/dev/whatsnew/3.12.html#ensurepip

@anilbey anilbey merged commit b9b2d15 into master Jan 8, 2024
@anilbey anilbey deleted the py312 branch January 8, 2024 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants