Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

add missing tests for 6 cppcore functions #354

Merged
merged 5 commits into from
Jan 11, 2024
Merged

add missing tests for 6 cppcore functions #354

merged 5 commits into from
Jan 11, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Jan 11, 2024 •
edited
Loading

Description

Some functions in the cppcore were not tested. This PR covers those.

  • Adds tests for 6 of the cppcore functions.
  • Tells efel.reset to flush the GError from the previous run/runs

Checklist:

  • Unit tests are added to cover the changes.
  • The changes are mentioned in the documentation.
  • CHANGELOG.md is updated (skip if the change is not important for the changelog).

AurelienJaquier
AurelienJaquier approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@anilbey anilbey merged commit 2bd34e6 into master Jan 11, 2024
@anilbey anilbey deleted the tests branch January 11, 2024 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AurelienJaquier AurelienJaquier AurelienJaquier approved these changes

@ilkilic ilkilic Awaiting requested review from ilkilic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anilbey @AurelienJaquier