Merge pull request #16 from Boehringer-Ingelheim/dev

Dev

.Rbuildignore

@@ -5,4 +5,6 @@
 ^docs$
 ^README\.html$
 ^LICENSE$
-^\.github
+^\.github
+^doc$
+^Meta$

.gitignore

@@ -11,4 +11,8 @@ vignettes/*\.html
 vignettes/*\.R
 inst/validation/results/val_param.rds
 inst/validation/results/val_report.html
-tests/testthat/app/shiny_bookmarks
+tests/testthat/app/shiny_bookmarks
+inst/doc
+/doc/
+/Meta/
+man/*.Rd

.lintr.R

@@ -0,0 +1,21 @@
+linters <- lintr::default_linters             # -[ diff with dv.templates 3ca8d7a10cfc7ad2307644dcac603e1f1f0feb72]-
+linters <- lintr::modify_defaults(
+  linters
+  , line_length_linter = NULL                 # we see how long lines are when we write them
+  , indentation_linter = NULL
+  , trailing_whitespace_linter = NULL
+  , cyclocomp_linter = NULL                   # prevents trivial amount of nesting and long but straightforward functions
+  , object_name_linter = NULL                 # we have reasons to capitalize. nobody in our team CamelCase. shiny does
+  , object_length_linter = NULL               # we don't type long var names just because
+  , pipe_continuation_linter = NULL           # wickham being overly prescriptive
+  , trailing_blank_lines_linter = NULL        # natural extension of trailing_whitespace_linter, present on the template
+)
+
+if(identical(Sys.getenv('CI'), "true")){
+  linters <- lintr::modify_defaults(
+    linters
+    , object_usage_linter = NULL              # R lacks var declarations; it's easy to assign to the wrong variable by mistake
+  )                                           # We only disable this lint rule on github because it fails there because
+}                                             # of a long-standing lintr bug 
+
+exclusions <- list("tests")

DESCRIPTION

@@ -1,16 +1,17 @@
 Package: dv.listings
 Type: Package
 Title: Data listings module
-Version: 4.0.0
+Version: 4.1.0
 Authors@R: 
     c(
       person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")),
       person('Isabel', 'Glauss', email = '[email protected]', role = c('aut', 'cre')),
       person('Korbinian', 'Matthias', email = '[email protected]', role = c('aut')),
       person('Luis', 'Morís Fernández', email = '[email protected]', role = c('aut')),
-      person('Jessica', 'Knizia', email = '[email protected]', role = c('ctb'))
+      person('Jessica', 'Knizia', email = '[email protected]', role = c('ctb')),
+      person('Gurjinder', 'Mohan', email = '[email protected]', role = c('ctb'))
     )
-Description: DaVinci’s dv.listings package provides modules to display different dataset domains as listings. 
+Description: DaVinci’s dv.listings package provides a module to display different dataset domains as listings. 
     Users can select the dataset to be shown, and specify which columns of the dataset should be displayed.
     The displayed columns can be sorted and filtered.
     Moreover, the listing can be filtered to show only entries containing a keyword specified by the user.
@@ -30,7 +31,7 @@ Imports:
     checkmate (>= 2.1.0),
     dplyr (>= 1.0.5),
     DT (>= 0.18),
-    dv.manager (>= 2.0.0-17),
+    dv.manager (>= 2.1.4),
     htmlwidgets (>= 1.6.2),
     magrittr (>= 2.0.3),
     openxlsx (>= 4.2.5.2),
@@ -41,7 +42,7 @@ Imports:
     shinyjs (>= 2.1.0),
     shinyWidgets (>= 0.8.0),
     tibble (>= 3.2.1)
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
 Roxygen: list(markdown = TRUE)
 Remotes: boehringer-ingelheim/dv.manager@main
 VignetteBuilder: knitr

NEWS.md

@@ -1,3 +1,14 @@
+# dv.listings 4.1.0
+
+- Add jumping feature
+- The module allows now to 
+  - select all columns
+  - unselect all columns
+  - reset to default columns
+  - reset filters
+- Remove support for data dispatchers
+- Provide early feedback of module misconfiguration
+
 # dv.listings 4.0.0
 
 Package was renamed to dv.listings.