Add convenience macros for defining providers #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bonemind
reviewed
Oct 7, 2019
There was a problem hiding this comment.
I'm liking the Syringe.define_providers shortcut, It's a good addition to the api.
I'm still thinking about the define_singleton_providers shortcut, i'm torn between also adding Syringe.injectable_singleton, and leaving injectable singletons out of the shard entirely. I think there's merits to both, i'll think about it for a bit and get back to that today.
|
I've thought about it and think this is a useful enough addition, if you could add a Syringe.injectable_singleton feature for symmetries sake, and readme documentation I'm happy. |
|
👌 Happy to update once @elliotize's PR is merged. |
|
My PR I think is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Perhaps useful, this PR aims to add
define_singleton_providersanddefine_providersmacros to add bothinjectableandwrap(where applicable) functionality to classes, while honouring namespaces.Considerations
Depends on the work over at #3