-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Prompt and Parser separately #1505
base: canary
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with the giant PR
Can you also run the with_options test for all 3 langs, and collector tests in ruby, and ts? They should all pass.
Some nits on naming -- e.g. build_request in the internal pyo3 interface / other ones could be renamed to get_http_request_body -- as that is exactly what we return -- it's not headers or anything.
The external interface can remain b.request
In python integ tests there is a script that runs some tests on CI. You'll want to ignore your new test file there. This is why CI fails
} | ||
|
||
withOptions(baml_options: BamlCallOptions) { | ||
return new BamlSyncClient(this.runtime, this.ctx_manager, baml_options) | ||
withOptions(bamlOptions: BamlCallOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch with the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronvg build_request returns the entire HTTP request type (including headers, URL, method) not just the body.
#1403