Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable passwordless for macOS #495

Merged
merged 1 commit into from
Oct 29, 2024
Merged

disable passwordless for macOS #495

merged 1 commit into from
Oct 29, 2024

Conversation

cfbao
Copy link
Member

@cfbao cfbao commented Oct 28, 2024 •
edited
Loading

Testing suggests that DSSO isn't enabled/configured for macOS at D2L, so

  • we cannot test passwordless auth on macOS
  • enabling it would mean a few seconds of useless waiting for D2L Mac users and a subpar UX

Also reconsidering adding --disable-passwordless-auth as suggested before.

@cfbao cfbao marked this pull request as ready for review October 28, 2024 23:23
@cfbao cfbao requested a review from a team as a code owner October 28, 2024 23:23
boarnoah
boarnoah approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@boarnoah boarnoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate :(

Also reconsidering adding --disable-passwordless-auth as suggested before.

Why? Are you thinking in terms of, the fact its not setup in OSX is mostly a D2L thing?

@cfbao
Copy link
Member Author

cfbao commented Oct 29, 2024

Also reconsidering adding --disable-passwordless-auth as suggested before.

Why? Are you thinking in terms of, the fact its not setup in OSX is mostly a D2L thing?

Yes. Okta supports DSSO on Macs. It's D2L that doesn't.

The flag would also be useful on Windows in case someone wants to work off the VPN.

I won't add it right now, as I still want to release this week and avoid drastic changes, but I think this is on the table for a future minor update.

@boarnoah

@cfbao cfbao merged commit 9698451 into main Oct 29, 2024
9 checks passed
@cfbao cfbao deleted the no-dsso-mac branch October 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boarnoah boarnoah boarnoah approved these changes

@gord5500 gord5500 gord5500 approved these changes

@scowing scowing Awaiting requested review from scowing scowing is a code owner automatically assigned from Brightspace/vulcan

@AnimalXing AnimalXing Awaiting requested review from AnimalXing AnimalXing is a code owner automatically assigned from Brightspace/vulcan

Assignees
No one assigned
Labels
language/csharp size/S A small PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfbao @boarnoah @gord5500