feat: Filter: Add date-range to custom date range filter value component [GAUD-6578] #4764
Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
| * Date/time range input type | ||
| * @type {'date'|'date-time'} | ||
| */ | ||
| type: { type: String } |
There was a problem hiding this comment.
Another option would be to have a bool like hide-time. The advantage of type is in case in the future we need to do some sort of time-only range or some other state (though there are currently no plans for those)
There was a problem hiding this comment.
Of the two, I prefer the type approach for the reason you mentioned.
Another alternative we can contemplate is busting it into two different components, which might be overkill if the API is essentially the same and there isn't much in the way of conditional logic.
There was a problem hiding this comment.
Agreed - at this point (nor going forward) I don't see it as necessary to split them out.
| this.startValue = e.target.startValue ? getUTCDateTimeFromLocalDateTime(e.target.startValue, '0:0') : undefined; | ||
| this.endValue = e.target.endValue ? getUTCDateTimeFromLocalDateTime(e.target.endValue, '0:0') : undefined; |
There was a problem hiding this comment.
d2l-input-date-range values are only localized so this gets the UTC value for midnight on the selected date.
| end-value="${ifDefined(this.endValue)}" | ||
| label="Custom Range" | ||
| label="${this.localize('components.filter-dimension-set-date-time-range-value.text')}" |
There was a problem hiding this comment.
This would (potentially) be the same as the list item text if not set by the consumer. I'll be looking at accessibility in a follow up story so I'll do some testing at that point to see if that's too repetitive.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 3.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Jira ticket
Adds
typeproperty which defaults todate-timebut can be set todatein order to use ad2l-input-date-rangecomponent inside the custom date filter value component.