browser_repository.rs: Fix Firefox incognito argument #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not be `--private`, but `--private-window`. Also changed the incognito arguments for both Chrome and Firefox to use the canonical double dash instead of single dash.
|
Hey, Maarten. Good catch and thank you for the fix! Not sure how I never caught it before. Regarding AUR - I wasn't aware there's |
|
The Firefox fix is now released in 0.5.1. There's also a small addition for |
|
Thanks, you're the best! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be
--private, but--private-window. Probably explains why opening in incognito mode (when holding shift) does not work for me for Firefox profiles 😛Also, I changed the incognito arguments for both Chrome and Firefox to use the canonical double dash instead of single dash.
P.S.: Since I don't need a Rust toolchain set up on my machine, I don't want to use https://aur.archlinux.org/packages/browsers-git, so I created https://aur.archlinux.org/packages/browsers-bin. Let me know if I need to transfer ownership to you, but I'm happy to bump the version number once in a while 🙂