fix: Add close button to QR Code Reader #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pabl0cks
reviewed
Jun 12, 2024
There was a problem hiding this comment.
The solution looks good to me @ChangoMan! Added a couple of comments 🙌
However, when you close the QR code reader it will also close the Send modal now
I think is fine to open again the Send drawer on that edge case, it's just 1 click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a way to fix #65
The issue is, when the Send Drawer is open, it manipulates other parts of the website so nothing else can be interacted with. Only the elements in the drawer can be interacted with.
I'm adding a close button to the QR code reader, with
pointer-events-autothat will override this. However, when you close the QR code reader it will also close the Send modal now. I'm not sure how to prevent this, but this is a solution to the issue mentioned above.