Add useWalletConnectManager #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9 tasks
Pabl0cks
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Thank you Damu! Bottom drawer for transactions feels much better! 🙌
I think it is working fine, was running through some issues while interacting with mainnet dapps where I had to change network, but they were happening also in the previous WC code.
Sometimes was not passing the change network events to burner and other times was firing multiple confirms on burner, registered an issue in #60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactor to some of the WalletConnect code (now it uses a hook, we can keep improving this code).
We have 3 drawer components (the transaction confirmation modal was migrated to a drawer).