Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats sorting #17

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Stats sorting #17

merged 3 commits into from
Feb 4, 2025

Conversation

carletex
Copy link
Contributor

@carletex carletex commented Feb 3, 2025

Tweaked the stats page a bit:

  • Move "Flags" section to the top (I think it's a more interesting stat)
  • Sorted both sections ASC
  • Tweaked some column names
    image
    image

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ctf.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 9:19am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ctf-devcon ⬜️ Ignored (Inspect) Feb 4, 2025 9:19am

Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @carletex !! Definitely makes more sense with the updates, and is working nicely 🙌

Was playing a bit with the alignments. do you think is worth it to update it with one of these variations? Or prefer to keep it as it is.

image

@Pabl0cks
Copy link
Member

Pabl0cks commented Feb 4, 2025

Not related to this PR (sorry!) => Pushed a small tweak on FAQs for mobile that I found out after merging #18

Before vs After

image

@carletex
Copy link
Contributor Author

carletex commented Feb 4, 2025

Was playing a bit with the alignments. do you think is worth it to update it with one of these variations? Or prefer to keep it as it is.

I see a lot of numbers there :D I prefer the way it's. But let's merge to fix the current state and we can discuss later.

Not related to this PR (sorry!) => Pushed a small tweak on FAQs for mobile that I found out after merging #18

Thanks!

@carletex carletex merged commit d6d4cc8 into main Feb 4, 2025
4 checks passed
@carletex carletex deleted the stats-sorting branch February 4, 2025 09:59
@carletex
Copy link
Contributor Author

carletex commented Feb 4, 2025

Oops, sorry. I realized I interpreted it wrong.

I thought you were putting the two sections together. My bad for not reading properly haha

Can you create another PR for it?

Both look better than the current state, so up to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants