Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Added beaconV2 queries and updated some tests #98

Merged
merged 45 commits into from
Aug 11, 2021
Merged

Conversation

ViMuilu
Copy link
Member

@ViMuilu ViMuilu commented Jul 30, 2021

Description

Queries can now be done to multiple endpoints.

Related issues

#94

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes Made

  • Multiple endpoints can be queried this is done by passing the appropriate endpoint as a parameter.
  • Updated tests which were failing due to changes

Testing

There were some old tests which tested beaconV2 g_variants query so i didn't add any new tests.

@ViMuilu ViMuilu self-assigned this Jul 30, 2021
@ViMuilu ViMuilu force-pushed the feature/beaconV2_support branch from 13f4e62 to fdaf003 Compare August 2, 2021 11:00
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, beacon get added and i think queries are passed correctly, however we might need more integration tests for beacon v2 (which we can do in a different issue)

@ViMuilu ViMuilu merged commit 6470938 into dev Aug 11, 2021
@ViMuilu ViMuilu deleted the feature/beaconV2_support branch August 11, 2021 05:52
@blankdots blankdots mentioned this pull request Sep 29, 2021
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants