This repository was archived by the owner on Oct 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Added beaconV2 queries and updated some tests #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13f4e62
to
fdaf003
Compare
blankdots
reviewed
Aug 3, 2021
Co-authored-by: Stefan Negru <[email protected]>
blankdots
reviewed
Aug 3, 2021
Co-authored-by: Stefan Negru <[email protected]>
…/beacon-network into feature/gh_actions_build_beacon2.0
Update int.yml
Feature/gh actions builds beacon2.0
blankdots
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, beacon get added and i think queries are passed correctly, however we might need more integration tests for beacon v2 (which we can do in a different issue)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Queries can now be done to multiple endpoints.
Related issues
#94
Type of change
Changes Made
Testing
There were some old tests which tested beaconV2 g_variants query so i didn't add any new tests.