Agenda App #5
Open
Agenda App #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Initial setup & create contact logic
feat: Contact details page
feat: Edit contact & refactor
feat: Delete contact
feat: Search contacts
|
Please check my PR @mihaiandrei97 and @ivanms1. Thanks |
mihaiandrei97
approved these changes
Aug 2, 2023
ivanms1
approved these changes
Aug 4, 2023
Comment on lines
+75
to
+91
| {contactFile ? ( | ||
| <img | ||
| width={80} | ||
| height={80} | ||
| className="h-14 w-14 rounded-full border border-violet-400 bg-slate-300 object-cover object-center md:h-20 md:w-20" | ||
| src={contactFile} | ||
| alt={contactName} | ||
| /> | ||
| ) : ( | ||
| <img | ||
| width={80} | ||
| height={80} | ||
| className="h-14 w-14 rounded-full border border-violet-400 object-cover object-center md:h-20 md:w-20" | ||
| src="../../public/avatar_default.png" | ||
| alt="Default avatar" | ||
| /> | ||
| )} |
There was a problem hiding this comment.
Suggested change
| {contactFile ? ( | |
| <img | |
| width={80} | |
| height={80} | |
| className="h-14 w-14 rounded-full border border-violet-400 bg-slate-300 object-cover object-center md:h-20 md:w-20" | |
| src={contactFile} | |
| alt={contactName} | |
| /> | |
| ) : ( | |
| <img | |
| width={80} | |
| height={80} | |
| className="h-14 w-14 rounded-full border border-violet-400 object-cover object-center md:h-20 md:w-20" | |
| src="../../public/avatar_default.png" | |
| alt="Default avatar" | |
| /> | |
| )} | |
| <img | |
| width={80} | |
| height={80} | |
| className="h-14 w-14 rounded-full border border-violet-400 bg-slate-300 object-cover object-center md:h-20 md:w-20" | |
| src={contactFile || "../../public/avatar_default.png"} | |
| alt={contactName || Default avatar"} | |
| /> |
Comment on lines
+129
to
+148
| <div className="border-b border-slate-200 py-2"> | ||
| <p className="text-sm font-black">Mobile</p> | ||
| <p className="text-xs text-slate-400"> | ||
| {contactPhoneNumber} | ||
| </p> | ||
| </div> | ||
| <div className="border-b border-slate-200 py-2"> | ||
| <p className="text-sm font-black">Group</p> | ||
| <p className="text-xs text-slate-400">{contactGroup}</p> | ||
| </div> | ||
| <div className="border-b border-slate-200 py-2"> | ||
| <p className="text-sm font-black">Link numbers</p> | ||
| <p className="text-xs text-slate-400">{contactGroup}</p> | ||
| </div> | ||
| <div className="border-b border-slate-200 py-2"> | ||
| <p className="text-sm font-black">Add to favorites</p> | ||
| </div> | ||
| <div className="border-b border-slate-200 py-2"> | ||
| <p className="text-sm font-black">Share my location</p> | ||
| </div> |
There was a problem hiding this comment.
if these have all the same styles you could make a static array and map through it
Comment on lines
+94
to
+110
| {currentContact.contactFile ? ( | ||
| <img | ||
| width={48} | ||
| height={48} | ||
| className="mr-4 h-12 w-12 rounded-full border border-violet-400 object-cover object-center md:h-14 md:w-14" | ||
| src={currentContact?.contactFile} | ||
| alt={currentContact?.contactName} | ||
| /> | ||
| ) : ( | ||
| <img | ||
| width={48} | ||
| height={48} | ||
| className="mr-4 h-12 w-12 rounded-full border border-violet-400 object-cover object-center md:h-14 md:w-14" | ||
| src="../../public/avatar_default.png" | ||
| alt="Default avatar" | ||
| /> | ||
| )} |
Comment on lines
+139
to
+140
| <input | ||
| className="w-full rounded-2xl border border-gray-200 bg-gray-50 px-4 py-2 text-sm text-black placeholder:text-sm placeholder:text-gray-300" |
There was a problem hiding this comment.
maybe it will be nice to have an component that you can reuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.