Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATROID-1556 REFACTOR ShowTextAction to Kotlin #4799

Merged
merged 1 commit into from
Jun 23, 2023
Merged

CATROID-1556 REFACTOR ShowTextAction to Kotlin #4799

merged 1 commit into from
Jun 23, 2023

Conversation

Petrischale
Copy link
Contributor

@Petrischale Petrischale commented May 30, 2023 •
edited
Loading

Refactored ShowTextAction

Please enter a short description of your pull request and add a reference to the Jira ticket.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Hugoluk
Hugoluk approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@Hugoluk Hugoluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice refactor!

reichli
reichli requested changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@reichli reichli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Extracting the code into iteratActors is a good idea!
I just found two things (see comments in source code) which should be addressed before this ticket can be merged.

@Petrischale
CATROID-1556 REFACTOR ShowTextAction to Kotlin
e9321f3 
Refactored ShowTextAction

CATROID-1556 REFACTOR ShowTextAction to Kotlin

Implemented changes requested by Thomas.
Hugoluk
Hugoluk approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Hugoluk Hugoluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes are now added

reichli
reichli approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@reichli reichli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@reichli reichli merged commit c7428d0 into Catrobat:develop Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hugoluk Hugoluk Hugoluk approved these changes

@reichli reichli reichli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Petrischale @Hugoluk @reichli