WIP: Re-target IPO path to Jameson's branch #13
Conversation
| RT = Pair{Any, Tuple{Bool, Bool}} | ||
| good_effects = (true, true) | ||
| m = mi.def | ||
| if isa(invokee, Core.CodeInstance) | ||
| m = invokee.def.def |
There was a problem hiding this comment.
Eventually (including in Base) we may need to deal with the fact that going from CodeInstance back to MethodInstance may require some extra care to preserve the implied owner, world bounds, and edges information, and invoke pointer that was previously specified. I don't think we have fully specified what that means yet for reflection queries like this, since now these could be cassette like overlays, with a different behavior and ABI owner than the original MethodInstance implied
| ccall(:jl_update_codeinst, Cvoid, (Any, Any, Int32, UInt, UInt, UInt32, Any, UInt8, Any, Any), | ||
| daef_ci, src, Int32(0), UInt(1)#=ci.min_world=#, old_ci.max_world, old_ci.ipo_purity_bits, | ||
| nothing, 0x0, debuginfo, CC.empty_edges) | ||
| ccall(:jl_mi_cache_insert, Cvoid, (Any, Any), old_ci.def, daef_ci) |
There was a problem hiding this comment.
Don't use these as ccalls as the function is internal and likely to change often. You also need to close your engine reservation, but you probably shouldn't be making a reservation at all as this seems probably too late to acquire one. If you know that recursion is structurally unsupported by this package, just use the CodeInstance constructor?
No description provided.