-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove peer penalization even on INVALID execution status #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3756 +/- ##
=======================================
Coverage 37.06% 37.06%
=======================================
Files 319 319
Lines 8712 8711 -1
Branches 1354 1354
=======================================
Hits 3229 3229
+ Misses 5341 5340 -1
Partials 142 142 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Feb 14, 2022
dapplion
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As per the optimistic sync spec,
https://github.com/ethereum/consensus-specs/pull/2770/files#diff-2b75236a9ab74fc85d4ce0967032deeea2faad9b1eafd93ac2b327c4d0d30cf2R117-R124
even INVALID shouldn't downscore the peers as it might cause network split because of the faulty ELs.
This PR now treats the INVALIDs same as other execution errors and throws
EXECUTION_ENGINE_ERROR
, which isn't meant to downscore the peers.Description
Part of #3731