Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file checking to filter unwanted files to be parsed #2506

Closed
ruigomescx opened this issue Mar 26, 2021 · 0 comments · Fixed by #3045
Closed

Add file checking to filter unwanted files to be parsed #2506

ruigomescx opened this issue Mar 26, 2021 · 0 comments · Fixed by #3045
Assignees
@cx-joao-reigota
Labels
feature New feature
Milestone
Core Engineering

Comments

@ruigomescx
Copy link
Collaborator

Description

Currently all files regarding the supported extensions are being parsed and taken in account when executing queries. Regarding .json and .yaml files, since the extension is a "generic" one (unlike .tf that is set for Terraform), these files may not have a structure of a IaC file that we support. To improve performance, we should add intelligence to the parsing stage to check each file before being parsed, to infer if it's a IaC file that we support.
@ruigomescx ruigomescx added the feature New feature label Mar 26, 2021
@ruigomescx ruigomescx added this to the Core Engineering milestone Mar 26, 2021
cx-joao-reigota added a commit that referenced this issue Apr 29, 2021
@cx-joao-reigota
Added file checking to filter unwanted files to be parsed #2506
30e7a45 
Signed-off-by: João Reigota <[email protected]>
@cx-joao-reigota cx-joao-reigota mentioned this issue Apr 29, 2021
Merged
rogeriopeixotocx pushed a commit that referenced this issue Apr 30, 2021
@cx-joao-reigota
feat(engine): Add file checking to filter unwanted files to be parsed (…
3d13a00 
…#2506)  (#3045)

Signed-off-by: João Reigota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cx-joao-reigota cx-joao-reigota

Labels
feature New feature
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging a pull request may close this issue.

feat(engine): Add file checking to filter unwanted files to be parsed #2506 Checkmarx/kics
2 participants
@ruigomescx @cx-joao-reigota