Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stringified json in error message #2967

Closed
cxlucas opened this issue Apr 23, 2021 · 2 comments · Fixed by #2983 or #3037
Closed

Stringified json in error message #2967

cxlucas opened this issue Apr 23, 2021 · 2 comments · Fixed by #2983 or #3037
Assignees
@felipe-avelar
Labels
bug Something isn't working
Milestone
CLI/UI

Comments

@cxlucas
Copy link
Contributor

cxlucas commented Apr 23, 2021 •
edited
Loading

Expected Behavior

Show an error message "unknown

Actual Behavior

Displays the error message "unknown flag" and a stringified json in the end of output.

save

Steps to Reproduce the Problem

  1. Open terminal.
  2. Go to kics folder.
  3. Run: 'kics --any'

Specifications

  • Version: 1.2.4
  • Platform: any
  • Subsystem: n/a
@cxlucas cxlucas added the bug Something isn't working label Apr 23, 2021
@rogeriopeixotocx rogeriopeixotocx changed the title stringified json in error message Stringified json in error message Apr 23, 2021
@felipe-avelar felipe-avelar added this to the CLI/UI milestone Apr 23, 2021
@felipe-avelar
Copy link
Contributor

@cxlucas also reproduced this problem when using unknown commands, as can be seen on following image:
MicrosoftTeams-image

@felipe-avelar felipe-avelar mentioned this issue Apr 23, 2021
Merged
felipe-avelar added a commit that referenced this issue Apr 26, 2021
@felipe-avelar
fix(log): unwanted json log when using unknown flag/command (#2967) (#…
88a5703 
…2983)

* Removed log from unknown flag or command, since it happens before logger is set
Signed-off-by: Felipe Avelar <[email protected]>
@felipe-avelar felipe-avelar mentioned this issue Apr 28, 2021
Merged
@felipe-avelar
Copy link
Contributor

If a flag must have arguments, but not receives, it will reproduce the bug, e.g.: go run ./cmd/console/main.go scan -p valid_path --fail-on

@felipe-avelar felipe-avelar reopened this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipe-avelar felipe-avelar

Labels
bug Something isn't working
Projects
None yet
Milestone
CLI/UI
2 participants
@felipe-avelar @cxlucas