Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On invalid log path - log is created in cwd #3155

Closed
LeonidWeinberg opened this issue May 7, 2021 · 1 comment · Fixed by #3290
Closed

On invalid log path - log is created in cwd #3155

LeonidWeinberg opened this issue May 7, 2021 · 1 comment · Fixed by #3290
Assignees
@cx-joao-reigota
Labels
bug Something isn't working

Comments

@LeonidWeinberg
Copy link

Expected Behavior

Log file invalid filename exception thrown

Actual Behavior

Log file created in cwd

Steps to Reproduce the Problem

  1. run command: kics scan --output-path ./../output --path ./../project --log-path log./../wow.log
  2. log is created in cwd instead of CLI error

Specifications

  • Version: 1.3.0
  • Platform: windows
  • Subsystem:
@LeonidWeinberg LeonidWeinberg added the bug Something isn't working label May 7, 2021
@LeonidWeinberg
Copy link
Author

It still reproduces for me

cx-joao-reigota added a commit that referenced this issue May 12, 2021
@cx-joao-reigota
Fix bug with invalid log path #3155
e26b1d7 
Signed-off-by: João Reigota <[email protected]>
@cx-joao-reigota cx-joao-reigota mentioned this issue May 12, 2021
Merged
rogeriopeixotocx pushed a commit that referenced this issue May 12, 2021
@cx-joao-reigota
fix(logs): Fix invalid log path not returning error #3155 #3290
90ab12e 
Signed-off-by: João Reigota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cx-joao-reigota cx-joao-reigota

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(logs): Fix invalid log path not returning error #3155 Checkmarx/kics
2 participants
@cx-joao-reigota @LeonidWeinberg