Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 'Log Min Messages Invalid Value' query for Ansible #1882

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Update 'Log Min Messages Invalid Value' query for Ansible #1882

merged 1 commit into from
Jan 29, 2021

Conversation

mcarvalhox
Copy link
Contributor

Closes #1880

Proposed Changes

  • Verifying if the flag's name is log_min_messages before checking its value in check_database_flags_content assures no other flags will appear in the results.

@mcarvalhox mcarvalhox added enhancement Enhancement query New query feature gcp ansible Ansible query labels Jan 29, 2021
@mcarvalhox mcarvalhox added this to the Query Accuracy milestone Jan 29, 2021
@mcarvalhox mcarvalhox requested a review from ruigomescx January 29, 2021 11:09
@mcarvalhox mcarvalhox self-assigned this Jan 29, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Jan 29, 2021

Scan submitted to Checkmarx

@github-actions
Copy link
Contributor

Unit Test Results

       1 files       19 suites   15s ⏱️
3 368 tests 3 368 ✔️ 0 💤 0 ❌

Results for commit 0651776.

@kicsbot
Copy link
Contributor

kicsbot commented Jan 29, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 3 vulnerabilities
High 0 High
Medium 2 Medium
Low 1 Low
Info 0 Info

Violation Summary

Medium 2 Medium

View more details on Checkmarx UI

Cx-SAST Details

Lines Severity Category File Link
30 Medium Path_Traversal cmd/builder/main.go Checkmarx
66 Medium Denial_Of_Service_Resource_Exhaustion pkg/kics/service.go Checkmarx

@ruigomescx ruigomescx merged commit 6835c1e into master Jan 29, 2021
@ruigomescx ruigomescx deleted the feature/fix_ansible_gcp_queries branch January 29, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruigomescx ruigomescx ruigomescx approved these changes

@jorge-cruz jorge-cruz Awaiting requested review from jorge-cruz

@Ruben-Silva Ruben-Silva Awaiting requested review from Ruben-Silva

@joaomartinscx joaomartinscx Awaiting requested review from joaomartinscx

Assignees

@mcarvalhox mcarvalhox

Labels
ansible Ansible query enhancement Enhancement query New query feature
Projects
None yet
Milestone
Query Accuracy
Development

Successfully merging this pull request may close these issues.

Update 'Log Min Messages Invalid Value' query for Ansible
3 participants
@mcarvalhox @kicsbot @ruigomescx