Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected source to get libraries path based on queries path flag #1967

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

felipe-avelar
Copy link
Contributor

Signed-off-by: Felipe Avelar [email protected]

Closes #1964

Proposed Changes

  • Changed to try to find libraries folder on same level as queries folder from assets

@kicsbot
Copy link
Contributor

kicsbot commented Feb 3, 2021

Scan submitted to Checkmarx

@felipe-avelar felipe-avelar self-assigned this Feb 3, 2021
@felipe-avelar felipe-avelar added the bug Something isn't working label Feb 3, 2021
@felipe-avelar felipe-avelar added this to the Core Engineering milestone Feb 3, 2021
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@rogeriopeixotocx rogeriopeixotocx dismissed their stale review February 3, 2021 15:59

failing tests

@felipe-avelar felipe-avelar force-pushed the hotfix/correct_libraries_path branch from a8fa6f2 to 0b2ee14 Compare February 3, 2021 16:20
@kicsbot
Copy link
Contributor

kicsbot commented Feb 3, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 2 vulnerabilities
High 0 High
Medium 2 Medium
Low 0 Low
Info 0 Info

Violation Summary

Medium 2 Medium

View more details on Checkmarx UI

Cx-SAST Details

Lines Severity Category File Link
31 Medium Path_Traversal cmd/builder/main.go Checkmarx
66 Medium Denial_Of_Service_Resource_Exhaustion pkg/kics/service.go Checkmarx

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

Linux - Unit Test Statistics

       1 files       19 suites   17s ⏱️
3 368 tests 3 368 ✔️ 0 💤 0 ❌

Results for commit 11c71b7.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

Windows - Unit Test Statistics

       1 files       19 suites   25s ⏱️
3 368 tests 3 368 ✔️ 0 💤 0 ❌

Results for commit 11c71b7.

@ruigomescx ruigomescx merged commit 1f8b8fe into master Feb 5, 2021
@ruigomescx ruigomescx deleted the hotfix/correct_libraries_path branch February 5, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KICS failing to scan when queries path is not in same context as kics execution
4 participants