Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed case sensitive issues with type flag and fixed bug with dup types #2097

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

cx-joao-reigota
Copy link
Collaborator

fixed case sensitive issues with type flag and fixed bug with dup types #2092

Closes #2092

Proposed Changes

  • type flag now ignores case sensitive
    -fixed bug where if two extensions add the same type it would appear duplicated invalid arguments

I submit this contribution under Apache-2.0 license.

@cx-joao-reigota cx-joao-reigota added bug Something isn't working enhancement Enhancement labels Feb 18, 2021
@cx-joao-reigota cx-joao-reigota added this to the Quality milestone Feb 18, 2021
@cx-joao-reigota cx-joao-reigota self-assigned this Feb 18, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Feb 18, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Feb 18, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 2 vulnerabilities
High 0 High
Medium 2 Medium
Low 0 Low
Info 0 Info

Violation Summary

Medium 2 Medium

View more details on Checkmarx UI

Cx-SAST Details

Lines Severity Category File Link
31 Medium Path_Traversal cmd/builder/main.go Checkmarx
82 Medium Denial_Of_Service_Resource_Exhaustion pkg/kics/service.go Checkmarx

@github-actions
Copy link
Contributor

Linux - Unit Test Statistics

       1 files       20 suites   36s ⏱️
3 336 tests 3 336 ✔️ 0 💤 0 ❌

Results for commit f490615.

@github-actions
Copy link
Contributor

Windows - Unit Test Statistics

       1 files       20 suites   39s ⏱️
3 336 tests 3 336 ✔️ 0 💤 0 ❌

Results for commit f490615.

Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 9e1817f into master Feb 19, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix-type-case-sensitive branch February 19, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type flag shouldn't be case sensitive
3 participants