Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug with empty type flag #2135 #2137

Merged
merged 1 commit into from
Feb 25, 2021
Merged

fix bug with empty type flag #2135 #2137

merged 1 commit into from
Feb 25, 2021

Conversation

cx-joao-reigota
Copy link
Collaborator

Closes #2135

Proposed Changes

  • fixed bug where you couldn't pass the flag types empty

I submit this contribution under Apache-2.0 license.

@cx-joao-reigota cx-joao-reigota added the bug Something isn't working label Feb 25, 2021
@cx-joao-reigota cx-joao-reigota self-assigned this Feb 25, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Feb 25, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Feb 25, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 2 vulnerabilities
High 0 High
Medium 2 Medium
Low 0 Low
Info 0 Info

Violation Summary

Medium 2 Medium

View more details on Checkmarx UI

Cx-SAST Details

Lines Severity Category File Link
31 Medium Path_Traversal cmd/builder/main.go Checkmarx
81 Medium Denial_Of_Service_Resource_Exhaustion pkg/kics/service.go Checkmarx

@github-actions
Copy link
Contributor

Linux - Unit Test Statistics

       1 files       20 suites   38s ⏱️
3 361 tests 3 361 ✔️ 0 💤 0 ❌

Results for commit e7eadf8.

@github-actions
Copy link
Contributor

Windows - Unit Test Statistics

       1 files       20 suites   42s ⏱️
3 361 tests 3 361 ✔️ 0 💤 0 ❌

Results for commit e7eadf8.

rogeriopeixotocx
rogeriopeixotocx approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx
Copy link
Contributor

tested:
image

image

@rogeriopeixotocx rogeriopeixotocx merged commit 36cb784 into master Feb 25, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix-empty-type-flag branch February 25, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@ruigomescx ruigomescx Awaiting requested review from ruigomescx

@felipe-avelar felipe-avelar Awaiting requested review from felipe-avelar

Assignees

@cx-joao-reigota cx-joao-reigota

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty type flag gives panic error
3 participants
@cx-joao-reigota @kicsbot @rogeriopeixotocx