Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to terraform vars #2675

Merged
merged 14 commits into from
Apr 7, 2021
Merged

Add support to terraform vars #2675

merged 14 commits into from
Apr 7, 2021

Conversation

felipe-avelar
Copy link
Contributor

Closes #2226

Proposed Changes

  • Add support to terraform input variables
    I submit this contribution under Apache-2.0 license.

@felipe-avelar felipe-avelar added feature New feature terraform Terraform query labels Apr 1, 2021
@felipe-avelar felipe-avelar added this to the Core Engineering milestone Apr 1, 2021
@felipe-avelar felipe-avelar self-assigned this Apr 1, 2021
@felipe-avelar
Resolved codacy issue
3dc97bf 
Signed-off-by: Felipe Avelar <[email protected]>
@felipe-avelar felipe-avelar requested a review from ruigomescx April 1, 2021 16:06
@felipe-avelar
Updated tests paths
e726af8 
Signed-off-by: Felipe Avelar <[email protected]>
@felipe-avelar
Removing junit report generation
08ab5ac 
Signed-off-by: Felipe Avelar <[email protected]>
@felipe-avelar
Corrected tests for windows
c62c95a 
Signed-off-by: Felipe Avelar <[email protected]>
rogeriopeixotocx
rogeriopeixotocx previously approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM LCTM

cx-joao-reigota
cx-joao-reigota reviewed Apr 5, 2021
View reviewed changes
@felipe-avelar felipe-avelar force-pushed the feature/terraform-variables branch from e34c093 to ae0ca51 Compare April 5, 2021 15:46
cx-joao-reigota
cx-joao-reigota previously approved these changes Apr 5, 2021
View reviewed changes
Copy link
Collaborator

@cx-joao-reigota cx-joao-reigota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rogeriopeixotocx
rogeriopeixotocx approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit d32cc50 into master Apr 7, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/terraform-variables branch April 7, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@ruigomescx ruigomescx Awaiting requested review from ruigomescx

@cx-joao-reigota cx-joao-reigota Awaiting requested review from cx-joao-reigota

Assignees

@felipe-avelar felipe-avelar

Labels
feature New feature terraform Terraform query
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging this pull request may close these issues.

Support to Terraform variables
3 participants
@felipe-avelar @cx-joao-reigota @rogeriopeixotocx