Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug that panics KICS when queries path not exists #2732

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Fixed bug that panics KICS when queries path not exists #2732

merged 2 commits into from
Apr 7, 2021

Conversation

felipe-avelar
Copy link
Contributor

Signed-off-by: Felipe Avelar [email protected]

Closes #2731

Proposed Changes

  • Returns an error when inspector couldn't be created on scan, instead of only logging the error.

I submit this contribution under Apache-2.0 license.

@felipe-avelar felipe-avelar added the bug Something isn't working label Apr 7, 2021
@felipe-avelar felipe-avelar added this to the Core Engineering milestone Apr 7, 2021
@felipe-avelar felipe-avelar self-assigned this Apr 7, 2021
@felipe-avelar
Fixed test for default.go
5042296 
Signed-off-by: Felipe Avelar <[email protected]>
rogeriopeixotocx
rogeriopeixotocx approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 59eac1c into master Apr 7, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/queries-path-fix branch April 7, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@cx-joao-reigota cx-joao-reigota Awaiting requested review from cx-joao-reigota

Assignees

@felipe-avelar felipe-avelar

Labels
bug Something isn't working
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging this pull request may close these issues.

Panic when queries path not found
2 participants
@felipe-avelar @rogeriopeixotocx