Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix malformed files not reporting error #2754

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Fix malformed files not reporting error #2754

merged 3 commits into from
Apr 9, 2021

Conversation

cx-joao-reigota
Copy link
Collaborator

Closes #1930

Proposed Changes

  • When there is a problem in terraform parse instead of removing problematic line KICS will report error

image

I submit this contribution under Apache-2.0 license.

@cx-joao-reigota cx-joao-reigota added the bug Something isn't working label Apr 9, 2021
@cx-joao-reigota cx-joao-reigota added this to the Queries Support milestone Apr 9, 2021
@cx-joao-reigota cx-joao-reigota self-assigned this Apr 9, 2021
felipe-avelar
felipe-avelar approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rogeriopeixotocx
rogeriopeixotocx approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit d1d77d7 into master Apr 9, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix_malformed_files_not_reporting_error branch April 9, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@felipe-avelar felipe-avelar felipe-avelar approved these changes

Assignees

@cx-joao-reigota cx-joao-reigota

Labels
bug Something isn't working
Projects
None yet
Milestone
Queries Support
Development

Successfully merging this pull request may close these issues.

KICS counting malformed files and not reporting error
3 participants
@cx-joao-reigota @rogeriopeixotocx @felipe-avelar