Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KICS not rendering Chart bug #2761 #2762

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

cx-joao-reigota
Copy link
Collaborator

Closes #2761

Proposed Changes

  • Fix bug where KICS was not rendering helm charts
  • Increased unit testing on checkConditions func

I submit this contribution under Apache-2.0 license.

@cx-joao-reigota cx-joao-reigota added the bug Something isn't working label Apr 9, 2021
@cx-joao-reigota cx-joao-reigota added this to the Core Engineering milestone Apr 9, 2021
@cx-joao-reigota cx-joao-reigota self-assigned this Apr 9, 2021
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 6bda11b into master Apr 9, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix_counters_bug branch April 9, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KICS not rendering helm charts
3 participants