Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics) print CPU and Memory usage in logs (#2379) #2961

Merged
merged 16 commits into from
Apr 26, 2021

Conversation

cx-joao-reigota
Copy link
Collaborator

@cx-joao-reigota cx-joao-reigota commented Apr 22, 2021

Signed-off-by: João Reigota [email protected]

Closes #2379

Proposed Changes

  • Added CPU and Memory usage to logs
  • Added hidden flag metrics with possible values of 'cpu', 'mem'

Added metrics to: get_queries, get_files, inspect, generate_report

MEM:

image

image

CPU:

image

image

I submit this contribution under Apache-2.0 license.

@cx-joao-reigota cx-joao-reigota added feature New feature go Pull requests that update Go code labels Apr 22, 2021
@cx-joao-reigota cx-joao-reigota added this to the Quality milestone Apr 22, 2021
@cx-joao-reigota cx-joao-reigota self-assigned this Apr 22, 2021
@rogeriopeixotocx rogeriopeixotocx changed the title Added CPU and Memory usage to logs #2379 feat(analytics) print CPU and Memory usage in logs (#2379) Apr 23, 2021
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just a few comments

Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check comments

felipe-avelar
felipe-avelar previously approved these changes Apr 26, 2021
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CPU and Memory usage to logs
3 participants