-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): KICS does not execute scan as default anymore #3030
Conversation
Signed-off-by: Felipe Avelar <[email protected]>
@@ -90,6 +90,13 @@ func TestConsole_Execute(t *testing.T) { //nolint | |||
wantErr: false, | |||
remove: "", | |||
}, | |||
{ | |||
name: "test_kics_fail_without_scan", | |||
args: []string{"kics", "--path", filepath.FromSlash("../../test/fixtures/tc-sim01/positive1.tf"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Signed-off-by: Felipe Avelar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Felipe Avelar <[email protected]>
Signed-off-by: Felipe Avelar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please accept this PR to get this change pushed into the runner as soon as possible. Checkmarx/kics-github-action#12 |
Signed-off-by: Felipe Avelar [email protected]
Closes #3029
Proposed Changes
I submit this contribution under the Apache-2.0 license.