Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): parametrizing query execution timeout #3047 #3048

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx commented Apr 29, 2021

Signed-off-by: Rogério Peixoto [email protected]

Closes #3047

Proposed Changes

  • add --timeout flag that determines the number of seconds a rego query will be evaluated until it gets canceled.
  • add the flag to the documentation
  • small fixes across .md files

I submit this contribution under the Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added feature New feature go Pull requests that update Go code labels Apr 29, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the CLI/UI milestone Apr 29, 2021
@rogeriopeixotocx rogeriopeixotocx self-assigned this Apr 29, 2021
@rogeriopeixotocx rogeriopeixotocx force-pushed the feature/parametrize-query-timeout branch from 5fb8d83 to 7bd1ee0 Compare April 29, 2021 16:05
@rogeriopeixotocx rogeriopeixotocx force-pushed the feature/parametrize-query-timeout branch from 7bd1ee0 to 781142d Compare April 29, 2021 17:03
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comment about docs, please

```
./kics scan -p <path-of-your-project-to-scan> -o <output-results.json>
```shell
./kics scan -p '<path-of-your-project-to-scan>' -o '<output-results.json>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this example, shouldn't we update it for -o flag? I mean, this still works, but I think it can confuse user, since it can be used to generate multiple result types...

Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 3cdf815 into master Apr 30, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/parametrize-query-timeout branch April 30, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parametrize query execution timeout
2 participants