-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): parametrizing query execution timeout #3047 #3048
Conversation
Signed-off-by: Rogério Peixoto <[email protected]>
5fb8d83
to
7bd1ee0
Compare
Signed-off-by: Rogério Peixoto <[email protected]>
7bd1ee0
to
781142d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check comment about docs, please
``` | ||
./kics scan -p <path-of-your-project-to-scan> -o <output-results.json> | ||
```shell | ||
./kics scan -p '<path-of-your-project-to-scan>' -o '<output-results.json>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about this example, shouldn't we update it for -o flag? I mean, this still works, but I think it can confuse user, since it can be used to generate multiple result types...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Rogério Peixoto [email protected]
Closes #3047
Proposed Changes
I submit this contribution under the Apache-2.0 license.