Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): log-format JSON printing to console without 'verbose' flag #3208

Merged
merged 2 commits into from
May 11, 2021

Conversation

cx-joao-reigota
Copy link
Collaborator

Signed-off-by: João Reigota [email protected]

Closes #3142

Proposed Changes

  • Fix Saving log file with json format prints it also on std without --verbose flag

I submit this contribution under the Apache-2.0 license.

@cx-joao-reigota cx-joao-reigota added the bug Something isn't working label May 10, 2021
@cx-joao-reigota cx-joao-reigota self-assigned this May 10, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 10, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 10, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

Signed-off-by: João Reigota <[email protected]>
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit a5f94a7 into master May 11, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/print_without_verbose_flag branch May 11, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving log file with json format prints it also on std without --verbose flag
3 participants